On Tue, 2007-06-19 at 18:12 +0100, Christoph Hellwig wrote: > fcp_lun is an unsigned long long (and should be a __be64), so casting > this to a struct type is not very nice. Care to add a version that > takes > a __be64 intead? In fact using that variant in scsi_scan.c might be > benefical aswell, so you could aswell just convert over the existing > scsilun_to_int.
Actually, I don't think this is necessary for zfcp: all of these lun values are input by a user and translated using a strtoull() so it's going to get highly confusing trying to keep the be64 label [whether it's desirable for s390 people to be entering BE LUN values is another matter]. I'd really rather not encourage the use of __be64 u64 for SCSI luns because it's asking for alignment issues ... instead, the internal struct scsi_lun contains all the necessary information, and is a stream of u8 in bus order. James - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
