On Tue, 7 Aug 2007 08:55:49 +0200 Jens Axboe <[EMAIL PROTECTED]> wrote:
> On Mon, Aug 06 2007, FUJITA Tomonori wrote: > > On Tue, 31 Jul 2007 23:12:26 +0300 > > Boaz Harrosh <[EMAIL PROTECTED]> wrote: > > > > > The tested Kernels: > > > > > > 1. Jens's sglist-arch > > > I was not able to pass all tests with this Kernel. For some reason when > > > bigger than 256 pages commands are queued the Machine will run out > > > of memory and will kill the test. After the test is killed the system > > > is left with 10M of memory and can hardly reboot. > > > I have done some prints at the queuecommand entry in scsi_debug.c > > > and I can see that I receive the expected large sg_count and bufflen > > > but unlike other tests I get a different pointer at scsi_sglist(). > > > In other tests since nothing is happening at this machine while in > > > the test, the sglist pointer is always the same. commands comes in, > > > allocates memory, do nothing in scsi_debug, freed, and returns. > > > I suspect sglist leak or allocation bug. > > > > Ok, I found the leak. > > > > > > From 011c05c2e514d1db4834147ed83526473711b0a3 Mon Sep 17 00:00:00 2001 > > From: FUJITA Tomonori <[EMAIL PROTECTED]> > > Date: Mon, 6 Aug 2007 16:16:24 +0900 > > Subject: [PATCH] fix sg chaining leak > > > > Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> > > --- > > drivers/scsi/scsi_lib.c | 1 - > > 1 files changed, 0 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c > > index 5884b1b..25988b9 100644 > > --- a/drivers/scsi/scsi_lib.c > > +++ b/drivers/scsi/scsi_lib.c > > @@ -48,7 +48,6 @@ static struct scsi_host_sg_pool scsi_sg_pools[] = { > > SP(32), > > SP(64), > > SP(128), > > - SP(256), > > }; > > #undef SP > > Thanks Tomo! Trying to catch up with mails, will apply this one right > away. You can add the following patch to your sglist branches: >From abd73c05d5f08ee307776150e1deecac7a709b60 Mon Sep 17 00:00:00 2001 From: FUJITA Tomonori <[EMAIL PROTECTED]> Date: Mon, 30 Jul 2007 23:01:32 +0900 Subject: [PATCH] zfcp: sg chaining support Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers/s390/scsi/zfcp_def.h | 1 + drivers/s390/scsi/zfcp_qdio.c | 6 ++---- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/s390/scsi/zfcp_def.h b/drivers/s390/scsi/zfcp_def.h index b36dfc4..0d80150 100644 --- a/drivers/s390/scsi/zfcp_def.h +++ b/drivers/s390/scsi/zfcp_def.h @@ -34,6 +34,7 @@ #include <linux/slab.h> #include <linux/mempool.h> #include <linux/syscalls.h> +#include <linux/scatterlist.h> #include <linux/ioctl.h> #include <scsi/scsi.h> #include <scsi/scsi_tcq.h> diff --git a/drivers/s390/scsi/zfcp_qdio.c b/drivers/s390/scsi/zfcp_qdio.c index 81daa82..60bc269 100644 --- a/drivers/s390/scsi/zfcp_qdio.c +++ b/drivers/s390/scsi/zfcp_qdio.c @@ -591,7 +591,7 @@ zfcp_qdio_sbals_from_segment(struct zfcp_fsf_req *fsf_req, unsigned long sbtype, */ int zfcp_qdio_sbals_from_sg(struct zfcp_fsf_req *fsf_req, unsigned long sbtype, - struct scatterlist *sg, int sg_count, int max_sbals) + struct scatterlist *sgl, int sg_count, int max_sbals) { int sg_index; struct scatterlist *sg_segment; @@ -607,9 +607,7 @@ zfcp_qdio_sbals_from_sg(struct zfcp_fsf_req *fsf_req, unsigned long sbtype, sbale->flags |= sbtype; /* process all segements of scatter-gather list */ - for (sg_index = 0, sg_segment = sg, bytes = 0; - sg_index < sg_count; - sg_index++, sg_segment++) { + for_each_sg(sgl, sg_segment, sg_count, sg_index) { retval = zfcp_qdio_sbals_from_segment( fsf_req, sbtype, -- 1.5.2.4 - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html