On Tue, 25 Sep 2007 22:45:53 -0500 James Bottomley <[EMAIL PROTECTED]> wrote:
> On Tue, 2007-09-25 at 23:34 -0400, Jeff Garzik wrote: > > Matthew Wilcox wrote: > > > On Tue, Sep 25, 2007 at 10:37:33PM -0400, Jeff Garzik wrote: > > >> Are there any const-ness worries for scsi_host_template, or plans for > > >> the future? I do not see any other examples of the host template > > >> members getting modified. > > > > > > Goodness, Jeff, you haven't looked too hard. There's dozens of examples > > > I've come across trawling the horrible unmaintained drivers. I'd love > > > to see scsi_host_template become const, but it's not happening any time > > > soon, and we can address this little piece when the time comes. > > > > Well, sure, the driver is the owner of that memory. > > > > We're talking about common code. > > > > If everybody agrees SHT is R/W in the core, Fujita-san's patch is fine. > > Well, I don't like mucking with the template either. > > This whole mess is generated basically because the zero default of the > template should be treated as initiator. How about this, which makes > that manifest? But how can we handle dual-mode drivers? luce:/sys/class/scsi_host/host0$ cat supported_mode Initiator, Target The values are not enumerated. They are like FC_PORT_ROLE. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
