On Sat, 1 Dec 2007, James Bottomley wrote: > On Thu, 2007-11-29 at 15:18 -0800, Andrew Morton wrote: > > Guys, I have this marked as needed-in-2.6.24? > > Could you wait on this a bit ... since it's such an old bug. The code > in question needs to be reworked (as the comment says). I think the > best rework is to have the caller pass in an optional struct > scsi_sense_header into scsi_test_unit_ready() instead of the hacky > media_may_be_present, so the one place that needs this will be able to > interpret the sense codes correctly. > > I can do this when I get back home ... unfortunately, I'm in Aswan today > at an Internet café ... I'll be back in Cairo tomorrow, but my US system > seems to have fallen off the internet, so I might not be able to test > any patches I come up with. Worst case, I'll be back in Chicago on > Thursday.
That's fine with me. But the optional scsi_sense_header should be added in two places, not just one: There's the medium-detection code in sr.c already in this patch, and there's the medium-detection code in sd.c (it was changed in my original patch but not in this one). Alan Stern - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
