One more comment on the patch...

On Sun, Feb 03, 2008 at 06:28:48PM +0200, Boaz Harrosh wrote:
> +     /* Check for overflow */
> +     if (buflen > scsi_bufflen(srb)) {

This really should have an unlikely() around it.  This is an often-executed
code path, and we want to optimize it as much as possible.

Matt

-- 
Matthew Dharm                              Home: [EMAIL PROTECTED] 
Maintainer, Linux USB Mass Storage Driver

Type "format c:"  That should fix everything.
                                        -- Greg
User Friendly, 12/18/1997

Attachment: pgpmp71REWTJX.pgp
Description: PGP signature

Reply via email to