Ke Wei wrote:
Added support for hotplug and wide port.
Signed-off-by: Ke Wei <[EMAIL PROTECTED]>
---
drivers/scsi/mvsas.c | 445 ++++++++++++++++++++++++++++++++++++++------------
1 files changed, 339 insertions(+), 106 deletions(-)
Technically speaking, everything is looking great so far.
We need to correct one process problem, and we should be able to get
your work into the 'mvsas' branch of scsi-misc-2.6.git... and soon
thereafter hopefully into the official upstream kernel.
The process problem is... when making revisions, we need to get the
full patch each time. In this case, each patch should be diff'd against
the current version in the 'mvsas' branch: version 0.1.
The succession of emails would look like this:
Email #1:
Subject: [PATCH] mvsas: make it work
Convert the skeleton mvsas driver into a real, working
driver. Currently, the following works:
SAS, SAS expanders, SAS wide ports
SATA devices, SATAPI
Signed-off-by: Ke Wei <[EMAIL PROTECTED]>
And then James, myself, other reviewers reply. Or, you add some new
features like hotplugging.
Each time, you must regenerate a full patch against the most git
repository revision:
If a previous patch of yours, version "0.2", has been applied
to git, then you would create your patch against version 0.2.
If a previous patch of yours has NOT yet been applied to git,
then you would create your patch against version 0.1.
Thus, in this case, version 0.1 is in 'mvsas' branch, so your second
email would then be
Email #2:
Subject: [PATCH v2] mvsas: make it work
Convert the skeleton mvsas driver into a real, working
driver. Currently, the following works:
SAS, SAS expanders, SAS wide ports
SATA devices, SATAPI
Signed-off-by: Ke Wei <[EMAIL PROTECTED]>
---
Changes since last posting (version 0.2):
- fix coding problem
And then you continue your work, and add another revision while everyone
else is sleeping, the third email would look like:
Email #3:
Subject: [PATCH v3] mvsas: make it work
Convert the skeleton mvsas driver into a real, working
driver. Currently, the following works:
SAS, SAS expanders, SAS wide ports
SATA devices, SATAPI
Signed-off-by: Ke Wei <[EMAIL PROTECTED]>
---
Changes since last posting (version 0.3):
- add hotplug support
- add wide port support
Changes since last posting (version 0.2):
- fix coding problem
Thus, you always create a patch against the most recent source code in
the git repository.
It is common for patches to go through a few revisions on the mailing
list, before it is applied to the git repository.
So anyway... send a patch against the latest #mvsas (version 0.1), and
that patch should go in rapidly.
Thanks! And keep up the good work,
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
