ACK Sincerely -- Mark Salyzyn
> -----Original Message----- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > Sent: Tuesday, February 12, 2008 6:06 PM > To: LKML > Cc: Marcin Slusarz; linux-scsi@vger.kernel.org; AACRAID; > [EMAIL PROTECTED] > Subject: [PATCH] scsi: le*_add_cpu conversion > > From: Marcin Slusarz <[EMAIL PROTECTED]> > > replace all: > little_endian_variable = > cpu_to_leX(leX_to_cpu(little_endian_variable) + > expression_in_cpu_byteorder); > with: > leX_add_cpu(&little_endian_variable, > expression_in_cpu_byteorder); > generated with semantic patch > > Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> > Cc: linux-scsi@vger.kernel.org > Cc: [EMAIL PROTECTED] > Cc: [EMAIL PROTECTED] > --- > drivers/scsi/aacraid/commsup.c | 2 +- > drivers/scsi/ips.c | 8 ++------ > 2 files changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/scsi/aacraid/commsup.c > b/drivers/scsi/aacraid/commsup.c > index 81b3692..3ac8c82 100644 > --- a/drivers/scsi/aacraid/commsup.c > +++ b/drivers/scsi/aacraid/commsup.c > @@ -594,7 +594,7 @@ void aac_consumer_free(struct aac_dev * > dev, struct aac_queue *q, u32 qid) > if (le32_to_cpu(*q->headers.consumer) >= q->entries) > *q->headers.consumer = cpu_to_le32(1); > else > - *q->headers.consumer = > cpu_to_le32(le32_to_cpu(*q->headers.consumer)+1); > + le32_add_cpu(q->headers.consumer, 1); > > if (wasfull) { > switch (qid) { > diff --git a/drivers/scsi/ips.c b/drivers/scsi/ips.c > index bb152fb..f45770a 100644 > --- a/drivers/scsi/ips.c > +++ b/drivers/scsi/ips.c > @@ -3696,9 +3696,7 @@ ips_send_cmd(ips_ha_t * ha, ips_scb_t * scb) > scb->cmd.basic_io.sg_count = scb->sg_len; > > if (scb->cmd.basic_io.lba) > - scb->cmd.basic_io.lba = > - cpu_to_le32(le32_to_cpu > - > (scb->cmd.basic_io.lba) + > + le32_add_cpu(&scb->cmd.basic_io.lba, > > le16_to_cpu(scb->cmd.basic_io. > > sector_count)); > else > @@ -3744,9 +3742,7 @@ ips_send_cmd(ips_ha_t * ha, ips_scb_t * scb) > scb->cmd.basic_io.sg_count = scb->sg_len; > > if (scb->cmd.basic_io.lba) > - scb->cmd.basic_io.lba = > - cpu_to_le32(le32_to_cpu > - > (scb->cmd.basic_io.lba) + > + le32_add_cpu(&scb->cmd.basic_io.lba, > > le16_to_cpu(scb->cmd.basic_io. > > sector_count)); > else > -- > 1.5.3.7 - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
