On Tue, Oct 02, 2012 at 07:15:46AM +0000, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger <[email protected]> > > This patch carries forward a work-around from tcm_loop to target > core code to explicitly clear control CDB READ paylods in order to > avoid bugs in scsi-generic user-space code for INQUIRY that do not > explicitly zero CDB payload memory.
I never understood why we'd limit this to loop. As far as I can see we can get the same issue using sg-passthrough ontop of vhost, and for the other drivers we'd simply rely on the drivers zeroing the pages. I'd be much happier if we'd just unconditionally do this for the control plane commands, as the performance over head for those should be negligible. A good place would be to do it as part of transport_kmap_data_sg, after adding a data direction flag to it so that we'll only do it for the from device direction. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
