On Fri, Mar 8, 2013 at 6:14 AM, Roland Dreier <rol...@kernel.org> wrote: > Nicholas A. Bellinger <n...@linux-iscsi.org> wrote: > > +EXPORT_SYMBOL(iscsit_get_transport);
> It's not clear to me why this needs to be exported. Who would use it > outside the core iscsi target module? Yep, as Nic noted, we're adding here an iscsi transport concept e.g in the same manner Mike did libiscsi back in 2005/6 when the iser initiator was pushed. This allows for multiple iscsi flavours to use a common code for common functionality. In the initiator area initially there were iscsi tcp and iser, later few iscsi HW offloads were merged too. Same story here. I think that the point is whether or not these APIs are needed, since once we agree on that, we need an header file and exporting of functions. As libiscsi.h resided under include/ it makes sense to me for this include to be located there too. Or. Or. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
