On Mon, Jun 10, 2013 at 09:40:50AM +0200, Hannes Reinecke wrote: > The 'eh_entry' list might be used even before scsi_softirq_done() > is called. Hence we should rather initialize it together with > the other eh-related variables.
As mentioned earlier I don't think moving the initialization from one random point in the middle of the lifetime of the command to another is a good idea. If we initialize it it should be when it is allocated. But looking at the code I can't see why it needs to be initialized at all. eh_entry is not used as the head of a list but just as the list link, and it's never tested for emptyness either, which shouldn't require it to be initialized at all. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
