James, Thanks for pointing this out. We will send the fix for this in the next patch-set.
-- Adheer > -----Original Message----- > From: James Bottomley [mailto:jbottom...@parallels.com] > Sent: Saturday, August 24, 2013 1:03 AM > To: Adheer Chandravanshi > Cc: micha...@cs.wisc.edu; linux-scsi; Vikas Chaudhary; Lalit Chandivade > Subject: Re: [PATCH 1/7] qla4xxx: Allow removal of failed session using > logout. > > On Mon, 2013-07-08 at 08:33 -0400, adheer.chandravan...@qlogic.com > wrote: > > + /* wait until next relogin is triggered using DF_RELOGIN and > > + * clear DF_RELOGIN to avoid invocation of further relogin > > + */ > > + wtime = jiffies + (HZ * RELOGIN_TOV); > > + do { > > + if (test_and_clear_bit(DF_RELOGIN, &ddb_entry->flags)) > > + goto ddb_logout_init; > > + > > + schedule_timeout_uninterruptible(HZ); > > + } while ((time_after(wtime, jiffies))); > > This looks a bit like a hand rolled wait_event_timeout() couldn't you use the > linux primitives? > > James
<<attachment: winmail.dat>>
