[PATCH 07/32] target: Convert struct alua_lu_gp_member to kref

[Andy Grover]

Signed-off-by: Andy Grover <agro...@redhat.com>
---
 drivers/target/target_core_alua.c |   24 +++++++++++++++---------
 include/target/target_core_base.h |    2 +-
 2 files changed, 16 insertions(+), 10 deletions(-)

diff --git a/drivers/target/target_core_alua.c 
b/drivers/target/target_core_alua.c
index 8c01ade..fe2eada 100644
--- a/drivers/target/target_core_alua.c
+++ b/drivers/target/target_core_alua.c
@@ -64,6 +64,16 @@ static void release_alua_lu_gp(struct kref *ref)
 #define get_alua_lu_gp(x) kref_get(&x->refcount)
 #define put_alua_lu_gp(x) kref_put(&x->refcount, release_alua_lu_gp)
 
+static void release_alua_lu_gp_mem(struct kref *ref)
+{
+       struct t10_alua_lu_gp_member *lu_gp_mem = container_of(ref, struct 
t10_alua_lu_gp_member, refcount);
+
+       kmem_cache_free(t10_alua_lu_gp_mem_cache, lu_gp_mem);
+}
+
+#define get_alua_lu_gp_mem(x) kref_get(&x->refcount)
+#define put_alua_lu_gp_mem(x) kref_put(&x->refcount, release_alua_lu_gp_mem)
+
 /*
  * REPORT_TARGET_PORT_GROUPS
  *
@@ -937,8 +947,7 @@ int core_alua_do_port_transition(
                                lu_gp_mem_node) {
 
                dev = lu_gp_mem->lu_gp_mem_dev;
-               atomic_inc(&lu_gp_mem->lu_gp_mem_ref_cnt);
-               smp_mb__after_atomic_inc();
+               get_alua_lu_gp_mem(lu_gp_mem);
                spin_unlock(&lu_gp->lu_gp_lock);
 
                spin_lock(&dev->t10_alua.tg_pt_gps_lock);
@@ -983,8 +992,7 @@ int core_alua_do_port_transition(
                spin_unlock(&dev->t10_alua.tg_pt_gps_lock);
 
                spin_lock(&lu_gp->lu_gp_lock);
-               atomic_dec(&lu_gp_mem->lu_gp_mem_ref_cnt);
-               smp_mb__after_atomic_dec();
+               put_alua_lu_gp_mem(lu_gp_mem);
        }
        spin_unlock(&lu_gp->lu_gp_lock);
 
@@ -1186,7 +1194,8 @@ core_alua_allocate_lu_gp_mem(struct se_device *dev)
        }
        INIT_LIST_HEAD(&lu_gp_mem->lu_gp_mem_node);
        spin_lock_init(&lu_gp_mem->lu_gp_mem_lock);
-       atomic_set(&lu_gp_mem->lu_gp_mem_ref_cnt, 0);
+
+       kref_init(&lu_gp_mem->refcount);
 
        lu_gp_mem->lu_gp_mem_dev = dev;
        dev->dev_alua_lu_gp_mem = lu_gp_mem;
@@ -1256,9 +1265,6 @@ void core_alua_free_lu_gp_mem(struct se_device *dev)
        if (!lu_gp_mem)
                return;
 
-       while (atomic_read(&lu_gp_mem->lu_gp_mem_ref_cnt))
-               cpu_relax();
-
        spin_lock(&lu_gp_mem->lu_gp_mem_lock);
        lu_gp = lu_gp_mem->lu_gp;
        if (lu_gp) {
@@ -1273,7 +1279,7 @@ void core_alua_free_lu_gp_mem(struct se_device *dev)
        }
        spin_unlock(&lu_gp_mem->lu_gp_mem_lock);
 
-       kmem_cache_free(t10_alua_lu_gp_mem_cache, lu_gp_mem);
+       put_alua_lu_gp_mem(lu_gp_mem);
 }
 
 struct t10_alua_lu_gp *core_alua_get_lu_gp_by_name(const char *name)
diff --git a/include/target/target_core_base.h 
b/include/target/target_core_base.h
index 5bdf0d5..2d56eaf 100644
--- a/include/target/target_core_base.h
+++ b/include/target/target_core_base.h
@@ -273,7 +273,7 @@ struct t10_alua_lu_gp {
 
 struct t10_alua_lu_gp_member {
        bool lu_gp_assoc;
-       atomic_t lu_gp_mem_ref_cnt;
+       struct kref refcount;
        spinlock_t lu_gp_mem_lock;
        struct t10_alua_lu_gp *lu_gp;
        struct se_device *lu_gp_mem_dev;
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html