> -----Original Message-----
> From: Ales Novak [mailto:alno...@suse.cz]
> Sent: Thursday, February 27, 2014 2:04 AM
> To: KY Srinivasan; James E.J. Bottomley
> Cc: linux-scsi@vger.kernel.org; linux-ker...@vger.kernel.org;
> jkos...@suse.cz; Ales Novak; Thomas Abraham
> Subject: [PATCH] scsi: storvsc_device_destroy NULL pointer fix
>
> If the initialization of storvsc fails, the storvsc_device_destroy() causes
> NULL
> pointer dereference.
>
> storvsc_bus_scan()
> scsi_scan_target()
> __scsi_scan_target()
> scsi_probe_and_add_lun(hostdata=NULL)
> scsi_alloc_sdev(hostdata=NULL)
>
> sdev->hostdata = hostdata
>
> now the host allocation fails
>
> __scsi_remove_device(sdev)
>
> calls sdev->host->hostt->slave_destroy() ==
> storvsc_device_destroy(sdev)
> access of sdev->hostdata->request_mempool
>
> Signed-off-by: Ales Novak <alno...@suse.cz>
> Signed-off-by: Thomas Abraham <tabra...@suse.com>
> Acked-by: Jiri Kosina <jkos...@suse.cz>
Signed-off-by: K. Y. Srinivasan <k...@microsoft.com>
> ---
> drivers/scsi/storvsc_drv.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index
> 17d7404..9969fa1 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -1419,6 +1419,9 @@ static void storvsc_device_destroy(struct
> scsi_device *sdevice) {
> struct stor_mem_pools *memp = sdevice->hostdata;
>
> + if (!memp)
> + return;
> +
> mempool_destroy(memp->request_mempool);
> kmem_cache_destroy(memp->request_pool);
> kfree(memp);
> --
> 1.8.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
