Hi all, I've received reports claiming they're seeing a double command completion occasionally when a command timeout happens.
Delving into it I found this this indeed might happening; reason being that the LLDD will only be informed about a timed-out command by calling scsi_try_to_abort_command(). Anytime before that the LLDD is free to assume the command is valid and might call scsi_done() on it. Which then will lead to interesting issues in the error handler. And while debugging this I've found we're setting DID_TIME_OUT incorrectly, which might lead to spurious command timeout detection. Hannes Reinecke (2): scsi_error: set DID_TIME_OUT correctly scsi: Do not complete timed-out command drivers/scsi/scsi.c | 2 ++ drivers/scsi/scsi_error.c | 16 +++++++++------- drivers/scsi/scsi_priv.h | 1 + 3 files changed, 12 insertions(+), 7 deletions(-) -- 1.7.12.4 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
