On 09/01/2014 12:09 AM, Christoph Hellwig wrote: > On Thu, Aug 28, 2014 at 07:33:22PM +0200, Hannes Reinecke wrote: >> Dumping the entire sense buffer might overwhelm the logging functions, >> so suppress it per default. > > Call me dumb, but I don't see anything in here that limits the dumps > to debug output. > Yeah, you're right. This patch is pretty pointless. I'll be removing it.
> Also if you return boolean-like values please use the bool type for it. > Also please switch scsi_normalize_sense over to return bool as well > while you're at it. > Ok. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
