On 09/06/14 16:40, Douglas Gilbert wrote:
On 14-09-05 11:25 AM, Bart Van Assche wrote:
An LLD must call scsi_remove_host() directly or indirectly from the
module
cleanup path. scsi_remove_host() triggers a call to
blk_cleanup_queue(). That
last function sets the flag QUEUE_FLAG_DYING which prevents that new
I/O is
queued and waits until previously queued requests have finished before
returning.
And they do call scsi_remove_host(). But they do that toward
the end of their clean-up. The problem that I observed has
already happened before that.
IOW I think the QUEUE_FLAG_DYING state needs to be set and
acknowledged as the first order of business by the code
that implements 'rmmod LLD'.
Hello Doug,
In the scsi_debug driver scsi_remove_host() is called from inside the
sdebug_driver_remove() callback function. Unless I have missed something
it is not guaranteed that that callback function is invoked before
unloading of the scsi_debug driver has finished. I think most of the
code in sdebug_driver_remove() should be moved to sdebug_remove_adapter().
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
