On Sat, 13 Sep 2014, Hans de Goede wrote:

> And set this quirk for the Seagate Expansion Desk (0bc2:2312), as that one
> seems to hang upon receiving an ATA_12 or ATA_16 command.
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=79511
> 
> Cc: sta...@vger.kernel.org # 3.16
> Signed-off-by: Hans de Goede <hdego...@redhat.com>

> --- a/drivers/usb/storage/usb.c
> +++ b/drivers/usb/storage/usb.c
> @@ -478,7 +478,8 @@ void usb_stor_adjust_quirks(struct usb_device *udev, 
> unsigned long *fflags)
>                       US_FL_CAPACITY_OK | US_FL_IGNORE_RESIDUE |
>                       US_FL_SINGLE_LUN | US_FL_NO_WP_DETECT |
>                       US_FL_NO_READ_DISC_INFO | US_FL_NO_READ_CAPACITY_16 |
> -                     US_FL_INITIAL_READ10 | US_FL_WRITE_CACHE);
> +                     US_FL_INITIAL_READ10 | US_FL_WRITE_CACHE |
> +                     US_FL_NO_ATA_1X);
>  
>       p = quirks;
>       while (*p) {
> @@ -543,6 +544,9 @@ void usb_stor_adjust_quirks(struct usb_device *udev, 
> unsigned long *fflags)
>               case 's':
>                       f |= US_FL_SINGLE_LUN;
>                       break;
> +             case 't':
> +                     f |= US_FL_NO_ATA_1X;
> +                     break;
>               case 'u':
>                       f |= US_FL_IGNORE_UAS;
>                       break;

You must not add an aditional value for a module parameter without 
documenting it in Documentation/kernel-parameters.txt.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to