Thanks Hannes and Christoph for the answers. The patch to vmw_pvscsi.c looks fine to me.
Acked-by: Arvind Kumar <[email protected]> Thanks! Arvind ________________________________________ From: Hannes Reinecke <[email protected]> Sent: Saturday, October 18, 2014 10:42 AM To: Arvind Kumar; Christoph Hellwig Cc: [email protected]; James Bottomley; [email protected] Subject: Re: [PATCH] vmw_pvscsi: fixup tagging On 10/17/2014 08:34 PM, Arvind Kumar wrote: > Hi Christoph, > > Thanks for the change. Sorry for the delay. The change looks fine to me. I > just have a question. > > The comment in include/scsi/scsi_cmnd.h says: > > struct scsi_cmnd { > ... > unsigned char tag; /* SCSI-II queued command tag */ > } > > Is that comment not right? Should we update that too? > The 'tag' field from the scsi_cmnd is indeed meant for the SCSI-II queued command tag. But due to recent changes 'struct request' also contains a tag number which is used to implement a tag map. So the 'tag; field from struct scsi_cmnd is basically obsolete, and we're working on removing it. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage [email protected] +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
