Hi Finn, On Wed, Nov 12, 2014 at 6:12 AM, Finn Thain <fth...@telegraphics.com.au> wrote: > Changes since v2: > - Give more precise addresses in platform resource initializers and
Thanks! > move PAGE_SIZE back to ioremap() arguments. Sorry, I think I didn't make myself clear, and you thus misunderstood. I meant PAGE_SIZE makes sense when ioremap()ing a small region at a hardcoded address, where you don't care about the exact size, as it will be rounded up to PAGE_SIZE anyway. When ioremap()ing resources, please use the size provided by the resource. > +static int __init sun3_scsi_probe(struct platform_device *pdev) > +{ > + struct Scsi_Host *instance; > + int error; > + struct resource *irq, *mem; > + unsigned char *ioaddr; > +#ifdef SUN3_SCSI_VME > + int i; > +#endif > + > + if (setup_can_queue > 0) > + sun3_scsi_template.can_queue = setup_can_queue; > + if (setup_cmd_per_lun > 0) > + sun3_scsi_template.cmd_per_lun = setup_cmd_per_lun; > + if (setup_sg_tablesize >= 0) > + sun3_scsi_template.sg_tablesize = setup_sg_tablesize; > + if (setup_hostid >= 0) > + sun3_scsi_template.this_id = setup_hostid & 7; > + > +#ifdef SUPPORT_TAGS > + if (setup_use_tagged_queuing < 0) > + setup_use_tagged_queuing = 1; > +#endif > + > +#ifdef SUN3_SCSI_VME > + ioaddr = NULL; > + for (i = 0; i < 2; i++) { > + unsigned char x; > + > + irq = platform_get_resource(pdev, IORESOURCE_IRQ, i); > + mem = platform_get_resource(pdev, IORESOURCE_MEM, i); > + if (!irq || !mem) > + break; > + > + ioaddr = sun3_ioremap(mem->start, PAGE_SIZE, Here ... > + SUN3_PAGE_TYPE_VME16); > + dregs = (struct sun3_dma_regs *)(ioaddr + 8); > + > + if (sun3_map_test((unsigned long)dregs, &x)) { > + unsigned short oldcsr; > + > + oldcsr = dregs->csr; > + dregs->csr = 0; > + udelay(SUN3_DMA_DELAY); > + if (dregs->csr == 0x1400) > + break; > + > + dregs->csr = oldcsr; > + } > + > + iounmap(ioaddr); > + ioaddr = NULL; > + } > + if (!ioaddr) > + return -ENODEV; > +#else > + irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > + mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + if (!irq || !mem) > + return -ENODEV; > + > + ioaddr = ioremap(mem->start, PAGE_SIZE); and here. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html