On Wed, Apr 29, 2015 at 10:17:59AM +0900, Akinobu Mita wrote: > This change broke ufs driver.
I'd claim the ufs driver, or rather more specifily the ufs spec had already been broken. That whole concept of keeping references to scsi devices to send commands to for host state changes is just fundamentally broken. > The reason for scsi_device_get() in ufshcd_set_dev_pwr_mode() is > to avoid manual delete of UFS device W-LUN by holding the reference > to it. So can we acquire shost->scan_mutex lock instead of > scsi_device_get()? I tried attached patch and it seems to be working, > but I would like to ask your opinion about this change. It seems like a reasonable workaround. But then again the concept of the driver hanging on scsi_devices is and will stay broken. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
