On 7/8/2015 10:41 AM, Hannes Reinecke wrote:
If a disk reports an ALUA 'transitioning' state we should not
try to spin up the device.

Signed-off-by: Hannes Reinecke <h...@suse.de>
---
  drivers/scsi/sd.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 7c0bdaa..180a6e8 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -1801,6 +1801,8 @@ sd_spinup_disk(struct scsi_disk *sdkp)
                if (sense_valid && sshdr.sense_key == NOT_READY) {
                        if (sshdr.asc == 4 && sshdr.ascq == 3)
                                break;  /* manual intervention required */
+                       if (sshdr.asc == 4 && sshdr.ascq == 0xa)
+                               break;  /* transitioning */
                        if (sshdr.asc == 4 && sshdr.ascq == 0xb)
                                break;  /* standby */
                        if (sshdr.asc == 4 && sshdr.ascq == 0xc)



Hi Hannes,

Just nit-picking, but do you think that these four if statements can be
re-organized to condition (asc == 4) once and OR on the rest?
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to