> -----Original Message----- > From: linux-block-ow...@vger.kernel.org [mailto:linux-block- > ow...@vger.kernel.org] On Behalf Of Martin K. Petersen > Sent: Wednesday, December 16, 2015 4:54 PM > To: linux-scsi@vger.kernel.org; linux-bl...@vger.kernel.org > Cc: Martin K. Petersen <martin.peter...@oracle.com> > Subject: [PATCH 3/3] block: Export max_dev_sectors_kb in sysfs > ... > diff --git a/Documentation/block/queue-sysfs.txt ... > @@ -55,9 +55,15 @@ logical_block_size (RO) > ----------------------- > This is the logcal block size of the device, in bytes.
Since you're in the vicinity, consider adding an i to logcal. > > +max_dev_sectors_kb (R) > +---------------------- The others use (RO) rather than just (R). > +This is the maximum number of kilobytes supported by the storage > +device for a READ or WRITE request. > + > max_hw_sectors_kb (RO) > ---------------------- > -This is the maximum number of kilobytes supported in a single data transfer. > +This is the maximum number of kilobytes supported by the storage > +controller in a single data transfer. ... > @@ -68,7 +74,8 @@ max_sectors_kb (RW) > ------------------- > This is the maximum number of kilobytes that the block layer will allow > for a filesystem request. Must be smaller than or equal to the maximum > -size allowed by the hardware. > +size allowed by the storage controller (max_hw_sectors_kb) and the > +maximum size allowed by the storage device (max_dev_sectors_kb). Each one uses a different phrase: * for a READ or WRITE request * in a single data transfer * for a filesystem request Is some subtle difference being implied? Since there are existing sysfs file with similar names, you're stuck using _kb for the new one. However, I suggest that the Documentation at least mention these are really KiB, not kilobyte, units. --- Robert Elliott, HPE Persistent Memory -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
