On 12/20/2015 01:35 AM, Mike Christie wrote: > On 12/15/2015 09:54 AM, Jitendra Bhivare wrote: >> From: Jitendra <[email protected]> >> >> This is second part of actual fix for soft lockup. >> >> All mbox cmds issued using BMBX and MCC are synchronized using mutex >> mbox_lock instead of spin_lock. Used mutex_lock_interruptible where >> ever possible. >> >> Signed-off-by: Jitendra <[email protected]> >> --- >> drivers/scsi/be2iscsi/be.h | 2 +- >> drivers/scsi/be2iscsi/be_cmds.c | 73 ++++++++++++++------------- >> drivers/scsi/be2iscsi/be_main.c | 2 +- >> drivers/scsi/be2iscsi/be_mgmt.c | 105 >> ++++++++++++++++++++------------------ >> 4 files changed, 94 insertions(+), 88 deletions(-) >> >> diff --git a/drivers/scsi/be2iscsi/be.h b/drivers/scsi/be2iscsi/be.h >> index 77f992e..cf19bce 100644 >> --- a/drivers/scsi/be2iscsi/be.h >> +++ b/drivers/scsi/be2iscsi/be.h >> @@ -124,7 +124,7 @@ struct be_ctrl_info { >> struct pci_dev *pdev; >> >> /* Mbox used for cmd request/response */ >> - spinlock_t mbox_lock; /* For serializing mbox cmds to BE card */ >> + struct mutex mbox_lock; /* For serializing mbox cmds to BE card */ > > You need to update free_mcc_tag. It still does spin_lock calls on the > mbox_lock. >
Ignore this. I see it is done in the 4th patch. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
