>>>>> "Maurizio" == Maurizio Lombardi <mlomb...@redhat.com> writes:

Jitendra,

Please review.

> In case of error, the memory allocated for phwi_ctrlr was not freed.
> 
> Signed-off-by: Maurizio Lombardi <mlomb...@redhat.com>
> ---
>  drivers/scsi/be2iscsi/be_main.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
> index 7a6dbfb..360aa88 100644
> --- a/drivers/scsi/be2iscsi/be_main.c
> +++ b/drivers/scsi/be2iscsi/be_main.c
> @@ -2706,8 +2706,10 @@ static int beiscsi_alloc_mem(struct beiscsi_hba *phba)
>       phwi_ctrlr->wrb_context = kzalloc(sizeof(struct hwi_wrb_context) *
>                                         phba->params.cxns_per_ctrl,
>                                         GFP_KERNEL);
> -     if (!phwi_ctrlr->wrb_context)
> +     if (!phwi_ctrlr->wrb_context) {
> +             kfree(phba->phwi_ctrlr);
>               return -ENOMEM;
> +     }
>  
>       phba->init_mem = kcalloc(SE_MEM_MAX, sizeof(*mem_descr),
>                                GFP_KERNEL);
> 

-- 
Martin K. Petersen      Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to