Sumit,

Please comment.

Thanks!

---8<---

Hello Sumit Saxena,

The patch 31796fa184ee: "megaraid_sas: Task management support" from
Jan 28, 2016, leads to the following static checker warning:

        drivers/scsi/megaraid/megaraid_sas_base.c:1788 
megasas_update_sdev_properties()
        warn: if statement not indented

drivers/scsi/megaraid/megaraid_sas_base.c
  1781          } else {
  1782                  device_id = ((sdev->channel % 2) * 
MEGASAS_MAX_DEV_PER_CHANNEL)
  1783                                          + sdev->id;
  1784                  local_map_ptr = fusion->ld_drv_map[(instance->map_id & 
1)];
  1785                  ld = MR_TargetIdToLdGet(device_id, local_map_ptr);
  1786                  raid = MR_LdRaidGet(ld, local_map_ptr);
  1787  
  1788                  if (raid->capability.ldPiMode == 
MR_PROT_INFO_TYPE_CONTROLLER)
  1789                  blk_queue_update_dma_alignment(sdev->request_queue, 
0x7);

It looks like the code is correct but the patch just deleted a tab
accidentally.

  1790                  mr_device_priv_data->is_tm_capable =
  1791                          raid->capability.tmCapable;
  1792          }


---8<---

-- 
Martin K. Petersen      Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to