On 02/22/2016 01:45 AM, Serguei Bezverkhi (sbezverk) wrote: > Hi Mike, > > I just wanted to follow up with you to see if the patch got committed to an > upstream kernel if yes, please let me into which version it went. > > Thank you > > Serguei > > > Serguei Bezverkhi, > TECHNICAL LEADER.SERVICES > Global SP Services > sbezv...@cisco.com > Phone: +1 416 306 7312 > Mobile: +1 514 234 7374 > > CCIE (R&S,SP,Sec) - #9527 > > Cisco.com > > > > Think before you print. > This email may contain confidential and privileged material for the sole use > of the intended recipient. Any review, use, distribution or disclosure by > others is strictly prohibited. If you are not the intended recipient (or > authorized to receive for the recipient), please contact the sender by reply > email and delete all copies of this message. > Please click here for Company Registration Information. > > > > -----Original Message----- > From: Mike Christie [mailto:micha...@cs.wisc.edu] > Sent: Friday, January 29, 2016 6:33 PM > To: Serguei Bezverkhi (sbezverk) <sbezv...@cisco.com> > Cc: bugzilla-dae...@bugzilla.kernel.org; linux-scsi@vger.kernel.org; > Christoph Hellwig <h...@infradead.org>; Hannes Reinecke <h...@suse.de> > Subject: Re: [Bug 111441] New: iscsi fails to attach to targets > > On 01/29/2016 04:21 PM, Serguei Bezverkhi (sbezverk) wrote: >> HI Mike, >> >> I tried your patch and it is has eliminated first traceback but I still do >> not see my remote targets. >> > > That is sort of expected. Your target is not setup for ALUA properly. It says > it supports ALUA, but when scsi_dh_alua asks about the ports it is reporting > there are none. Ccing the people that made the patch that added the issue and > own the code. > > Hey Christoph and Hannes, > > The dh/alua changes that added this: > > error = scsi_dh_add_device(sdev); > if (error) { > sdev_printk(KERN_INFO, sdev, > "failed to add device handler: %d\n", error); > return error; > } > > to scsi_sysfs_add_sdev are adding a regression. > > 1. If that fails, then we forget to do device_del before doing the return. My > patch in this thread added that back, so we do not see the sysfs oopses > anymore. But..... > > 2. It looks like in older kernels, we would allow misconfigured targets like > this one to still setup devices. Do we want that old behavior back? > Should we just ignore the return value from scsi_dh_add_device above? > Note that in this case, it is LIO so it can be easily fixed on the target > side by just setting it up properly. I do not think other targets would hit > this type of issue. > > This has been fixed up with my patchset to update the ALUA handler, most notably the commit 'scsi: ignore errors from scsi_dh_add_device()' which was included in 4.5.
Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
