On 02/29/2016 01:04 PM, Konrad Rzeszutek Wilk wrote: > On Mon, Feb 29, 2016 at 1:45 PM, Mike Christie <micha...@cs.wisc.edu> wrote: >> On 02/25/2016 12:15 PM, Lee Duncan wrote: >>> From: Hannes Reinecke <h...@suse.de> >>> >>> The iBFT table only specifies a prefix length, not a netmask. >>> And the netmask is pretty much pointless for IPv6. >>> So introduce a new attribute 'prefix-len' and display the >>> netmask attribute only for IPv4 addresses. >> >> The code looks ok to me, but I think this ipv4 comment was left over >> from the last posting since it conflicts with the comment below about >> always displaying it. Maybe it can just be edited when the patch is >> merged to avoid having to resend again. If so, >> >> Reviewed-by: Mike Christie <micha...@cs.wisc.edu> >> > > Cool. Let me roll it up and send the git pull to Linus.
I actually just resent it, but the only change was to truncate the last line of first paragraph of the comment to: So introduce a new attribute 'prefix-len'. > > This does not seem be super-urgent so it can wait for the upcoming merge > window? > >> >>> >>> Some older user-space code might rely on the netmask attribute >>> being present, so we should always display it. >>> >>> Changes from v1: >>> - Combined two patches into one >>> >>> Signed-off-by: Hannes Reinecke <h...@suse.de> >>> Signed-off-by: Lee Duncan <ldun...@suse.com> > -- Lee Duncan SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html