Hi Varun & Co, On Wed, 2016-03-02 at 17:30 +0530, Varun Prakash wrote: > On Tue, Mar 01, 2016 at 08:19:21PM +0530, Christoph Hellwig wrote: > > This looks like pretty random exports and not something like a well > > defined interface to me :( > > I have exported functions which works on iscsi-target data structures > and can be reused by offload drivers.
The main point here for cxgbit, as-is it's duplicating a lot of code vs. existing TCP code-paths using Linux/NET. Many of these symbols are related to ->iscsit_immediate_queue() and ->cxgbit_response_queue() support, which for cxgbit vs. existing TCP can both benefit using common code. That is, to start cxgbit should avoid using these two specific callbacks originally intended for iser-target, and for supporting traditional iscsi hw offloads we'll need to pursue: - New iscsit_transport per PDU callbacks invoked from iscsit_immediate_queue() + iscsit_response_queue() in iscsi_target.c, or - New iscsit_transport per PDU callbacks invoked from iscsi_send_$PDU() in iscsi_target.c. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html