Hello Satish Kharat,
This is a semi-automatic email about new static checker warnings.
The patch ce4b9e8980fa: "fnic: Using rport->dd_data to check rport
online instead of rport_lookup." from Mar 18, 2016, leads to the
following Smatch complaint:
drivers/scsi/fnic/fnic_scsi.c:457 fnic_queuecommand_lck()
warn: variable dereferenced before check 'rport' (see line 449)
drivers/scsi/fnic/fnic_scsi.c
448 rport = starget_to_rport(scsi_target(sc->device));
449 ret = fc_remote_port_chkready(rport);
^^^^^
Old dereference (inside function call).
450 if (ret) {
451 atomic64_inc(&fnic_stats->misc_stats.rport_not_ready);
452 sc->result = ret;
453 done(sc);
454 return 0;
455 }
456
457 if (rport) {
^^^^^
The patch adds a check but too late. Probably just delete the check?
458 struct fc_rport_libfc_priv *rp = rport->dd_data;
459
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
