On Mon, Jun 13, 2016 at 10:00:07PM -0700, James Bottomley wrote: > The untagged command case in the 53c700 driver has been broken since > host wide tags were enabled because the replaced scsi_find_tag() > function had a special case for the tag value SCSI_NO_TAG to retrieve > sdev->current_cmnd. The replacement function scsi_host_find_tag() has > no such special case and returns NULL causing untagged commands to > trigger a BUG() in the driver. Inspection shows that the 53c700 is the > only driver using this SCSI_NO_TAG case, so a local fix in the driver > suffices to fix this problem globally. > > Fixes: 64d513ac31b - "scsi: use host wide tags by default" > Cc: sta...@vger.kernel.org # 4.4+ > Reported-by: Helge Deller <del...@gmx.de> > Tested-by: Helge Deller <del...@gmx.de> > Signed-off-by: James Bottomley <j...@linux.vnet.ibm.com>
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
