On Fri, Jul 15, 2016 at 02:22:52AM +0800, Tom Yan wrote: > On 14 July 2016 at 01:03, Tejun Heo <t...@kernel.org> wrote: > > > > It's used to device max_sectors. > > > > Not really. "max_sectors" of ATA drives have been set to > BLK_DEF_MAX_SECTORS, for at least quite some time. > > > > > This is way too gratuitous. There's no rationale for it while it has > > actual real-world risks. max_sectors is staying at 65535. > > > > That's alright. I don't have strong opinion on whether we should bump > this anyway. So I suppose we should replace the TODO comment with > something like "avoid count to be 0000h"? And maybe also change > ATA_MAX_SECTORS to 255 (with comment "avoid count to be 00h")?
I'd just leave both alone. It's one sector difference one way or the other and those numbers have a pretty long history. There's no reason to disturb them at this point. There's no actual gain whatsoever but there is some actual risk. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
