On 08/04/2016 04:59 PM, Bart Van Assche wrote: > On 08/03/16 06:13, Hannes Reinecke wrote: >> As usual, comments and reviews are welcome. > > Great work :-) Have you been testing these patches against the LIO FCoE > target driver? In that case you might need to port the following patch > to LIO, a patch that fixes a subtle data corruption issue: > https://sourceforge.net/p/scst/svn/4969. > Indeed I have. With this patchset I've managed to run FCoE over virtio with LIO running on the host. Quite cool, methinks :-)
And indeed, your patch seem to be helping with the issues I've seen (mysterious out-of-order frames and wireshark complaining about invalid frames). Still a bit hackish, though. Can't we move the data destructor into the skb itself and not free the data in the target core? Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking [email protected] +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
