On 1/11/17, 1:08 PM, "Bart Van Assche" <bart.vanass...@sandisk.com> wrote:
>On 12/23/2016 08:23 PM, Himanshu Madhani wrote: >> From: Quinn Tran <quinn.t...@cavium.com> >> >> Move code code which converts Task Mgmt Command flags for >> ATIO to TCM #defines, from qla2xxx driver to tcm_qla2xxx >> driver. >> >> Reviewed-by: Christoph Hellwig <h...@lst.de> >> Signed-off-by: Quinn Tran <quinn.t...@cavium.com> >> Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com> >> --- >> drivers/scsi/qla2xxx/qla_target.c | 75 >> ++++---------------------------------- >> drivers/scsi/qla2xxx/qla_target.h | 6 ++- >> drivers/scsi/qla2xxx/tcm_qla2xxx.c | 39 +++++++++++++++++++- >> 3 files changed, 49 insertions(+), 71 deletions(-) >> >> diff --git a/drivers/scsi/qla2xxx/qla_target.c >> b/drivers/scsi/qla2xxx/qla_target.c >> index 47acc26..6e58848 100644 >> --- a/drivers/scsi/qla2xxx/qla_target.c >> +++ b/drivers/scsi/qla2xxx/qla_target.c >> @@ -1592,8 +1592,9 @@ static int __qlt_24xx_handle_abts(struct scsi_qla_host >> *vha, >> mcmd->sess = sess; >> memcpy(&mcmd->orig_iocb.abts, abts, sizeof(mcmd->orig_iocb.abts)); >> mcmd->reset_count = vha->hw->chip_reset; >> + mcmd->tmr_func = QLA_TGT_ABTS; >> >> - rc = ha->tgt.tgt_ops->handle_tmr(mcmd, lun, TMR_ABORT_TASK, >> + rc = ha->tgt.tgt_ops->handle_tmr(mcmd, 0, mcmd->tmr_func, >> abts->exchange_addr_to_abort); > >Does this change remove the last user of the 'lun' variable from this >function? If so, please remove that variable entirely. We will need to preserve lun variable, since handle_tmr is also called from qlt_issue_task_mgmt and qlt_handle_task_mgmt. > >Thanks, > >Bart.
