On Thu, 2017-02-16 at 15:32 +0100, Christoph Hellwig wrote: > On Thu, Feb 16, 2017 at 08:33:14AM +0100, Hannes Reinecke wrote: > > Any device might be setting a queuedata structure, so we need to > > check if the queuedata really belongs to a SCSI device before > > proceeding. > > Can you add a comment next to the scsi_is_sdev_device call explaining > it? The thing is a bit of a hack, but probably the best we can do for > now.
A much better approach would be to change the type of the argument of get_sdev_from_queue(). Bart.
