On 02/21/2017 07:46 PM, Dan Carpenter wrote: > We accidentally return an uninitialized variable on success. > > Fixes: b6ff1b14cdf4 ("[SCSI] scsi_dh: Update EMC handler") > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> > > diff --git a/drivers/scsi/device_handler/scsi_dh_emc.c > b/drivers/scsi/device_handler/scsi_dh_emc.c > index 4a7679f6c73d..f1578832ec7a 100644 > --- a/drivers/scsi/device_handler/scsi_dh_emc.c > +++ b/drivers/scsi/device_handler/scsi_dh_emc.c > @@ -358,7 +358,7 @@ static int clariion_prep_fn(struct scsi_device *sdev, > struct request *req) > static int clariion_std_inquiry(struct scsi_device *sdev, > struct clariion_dh_data *csdev) > { > - int err; > + int err = SCSI_DH_OK; > char *sp_model; > > sp_model = parse_sp_model(sdev, sdev->inquiry); > Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)