On Fri, 2017-03-31 at 13:02 +0300, Dmitry Monakhov wrote: > Another good example may be a bug with dirty page cache after blkdiscard > https://lkml.org/lkml/2017/3/22/789 . This simple bug result in crappy > fsimage if mkfs relay on discard_zeroes_data behaviour. > So IMHO basic blkdev test coverage is important filesystem testing. i.e. > important for xfstests.
Mixing up filesystem tests and block layer / block driver tests in the same directory is completely wrong. Block driver developers will be primarily interested in the block tests and may want to skip the filesystem tests. Filesystem developers will probably run the block tests only once and will likely run the filesystem tests repeatedly. Mixing up different kinds of tests in the same directory makes it unnecessarily hard to run block and filesystem tests separately. Bart.
