Christoph,

> Use a switch for the sense key, and remove two pointless variables
> that are only used once.

> -                             if (unmap)

The rationale behind the unmap variable was clarity and avoiding magic
values.

I'm OK with this, however:

> +                             if (SCpnt->cmnd[1] & 8) { /* UNMAP */

So I committed with that change.

-- 
Martin K. Petersen      Oracle Linux Engineering

Reply via email to