> -----Original Message-----
> From: Christoph Hellwig [mailto:h...@infradead.org]
> Sent: Tuesday, April 25, 2017 12:07 AM
> To: Mahesh Rajashekhara <mahesh.rajashekh...@microsemi.com>
> Cc: Dave Carroll <david.carr...@microsemi.com>; linux-scsi@vger.kernel.org;
> j...@linux.vnet.ibm.com; martin.peter...@oracle.com; dl-esc-Aacraid Linux
> Driver <aacr...@microsemi.com>
> Subject: Re: [PATCH v2 1/1] aacraid: pci_alloc_consistent() failures on ARM64
>
> On Wed, Apr 05, 2017 at 04:14:16PM +0530, Mahesh Rajashekhara wrote:
> > There were pci_alloc_consistent() failures on ARM64 platform.
> > Use dma_alloc_coherent() with GFP_KERNEL flag DMA memory allocations.
> >
> > Signed-off-by: Mahesh Rajashekhara <mahesh.rajashekh...@microsemi.com>
> > ---
> > v2:
> > - Removed platform specific MACRO and call dma_*_coherent routines
> directly.
> > - Removed all the casts to and from void * in the arguments and
> > return values
>
> The indentation is weird, and you're also adding memsets of the allocations
> which is a behavior change. Please take a look at the the attached version
> that
> fixes this up.
>
> If you really need the zeroing please send an additional patch to switch to
> dma_zalloc_coherent.
>
> ---
> From 522b355c4fe021822d385332de525c7de5c2b290 Mon Sep 17 00:00:00
> 2001
> From: Mahesh Rajashekhara <mahesh.rajashekh...@microsemi.com>
> Date: Wed, 5 Apr 2017 16:14:16 +0530
> Subject: aacraid: pci_alloc_consistent() failures on ARM64
>
> There were pci_alloc_consistent() failures on ARM64 platform.
> Use dma_alloc_coherent() with GFP_KERNEL flag DMA memory allocations.
>
> Signed-off-by: Mahesh Rajashekhara <mahesh.rajashekh...@microsemi.com>
> [hch: tweaked indentation, removed memsets]
> Signed-off-by: Christoph Hellwig <h...@lst.de>
> ---
Acked-by: Dave Carroll <david.carr...@microsemi.com>
