Hi Bart, > On May 19, 2017, at 4:27 PM, Bart Van Assche <bart.vanass...@sandisk.com> > wrote: > > On Fri, 2017-05-19 at 14:53 -0700, Himanshu Madhani wrote: >> [ ... ] >> -int ql2xexchoffld = 0; >> -module_param(ql2xexchoffld, uint, S_IRUGO|S_IWUSR); >> -MODULE_PARM_DESC(ql2xexchoffld, >> - "Number of exchanges to offload. " >> - "0 (Default)- Disabled."); >> +int ql2xtgtexchg = 1024; >> +module_param(ql2xtgtexchg, uint, 0644); >> +MODULE_PARM_DESC(ql2xtgtexchg, >> + "Number of target exchanges."); >> + >> +int ql2xiniexchg = 1024; >> +module_param(ql2xiniexchg, uint, 0644); >> +MODULE_PARM_DESC(ql2xtgtexchg, >> + "Number of initiator exchanges."); >> > > [ ... ] > >> -static int ql_dm_tgt_ex_pct = 50; >> -module_param(ql_dm_tgt_ex_pct, int, S_IRUGO|S_IWUSR); >> -MODULE_PARM_DESC(ql_dm_tgt_ex_pct, >> - "For Dual Mode (qlini_mode=dual), this parameter determines " >> - "the percentage of exchanges/cmds FW will allocate resources " >> - "for Target mode."); >> - > > Hello Himanshu and Quinn, > > Renaming internal variables is fine but renaming module parameters is not > acceptable. Please don't do this. > > Thanks, > > Bart.
Will update patch to preserve module parameter. Thanks, - Himanshu
