Hi Christoph, On Mon, Apr 9, 2018 at 9:50 AM, Christoph Hellwig <h...@infradead.org> wrote: > On Sun, Apr 08, 2018 at 02:45:32PM +1200, Michael Schmitz wrote: >> --- /dev/null >> +++ b/drivers/scsi/zorro_esp.c
>> + .driver_data = (unsigned long)&blizzard1230II_data, > > What most (or at least many) drivers do in PCI land is to just use > an enum of types in the driver_Data field and use that as an index for > for decisions later. It seems like that might be the cleaner method > here as well. That may work fine for a small number of differences. For more differences, the pointer to the feature struct is what most DT drivers use (of_device_id.data is a const void *). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds