Optimization -
No need to hold hba_lock in dpc context for reading atomic variable.

Signed-off-by: Shivasharan S <shivasharan.srikanteshw...@broadcom.com>
---
 drivers/scsi/megaraid/megaraid_sas_fusion.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c 
b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index 774e1c619ab2..e4c47e9d994c 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -3573,18 +3573,13 @@ megasas_complete_cmd_dpc_fusion(unsigned long 
instance_addr)
 {
        struct megasas_instance *instance =
                (struct megasas_instance *)instance_addr;
-       unsigned long flags;
        u32 count, MSIxIndex;
 
        count = instance->msix_vectors > 0 ? instance->msix_vectors : 1;
 
        /* If we have already declared adapter dead, donot complete cmds */
-       spin_lock_irqsave(&instance->hba_lock, flags);
-       if (atomic_read(&instance->adprecovery) == MEGASAS_HW_CRITICAL_ERROR) {
-               spin_unlock_irqrestore(&instance->hba_lock, flags);
+       if (atomic_read(&instance->adprecovery) == MEGASAS_HW_CRITICAL_ERROR)
                return;
-       }
-       spin_unlock_irqrestore(&instance->hba_lock, flags);
 
        for (MSIxIndex = 0 ; MSIxIndex < count; MSIxIndex++)
                complete_cmd_fusion(instance, MSIxIndex);
-- 
2.16.1

Reply via email to