On Fri, Nov 23, 2018 at 06:36:13PM +0100, David Disseldorp wrote:
> iscsi_target_mod is the only LIO fabric where fabric_ops.name differs
> from the fabric_ops.fabric_name string.
> fabric_ops.name is used when matching target/$fabric ConfigFS create
> paths, so rename it .fabric_alias and fallback to target/$fabric vs
> .fabric_name comparison if .fabric_alias isn't initialised.
> iscsi_target_mod is the only fabric module to set .fabric_alias . All
> other fabric modules rely on .fabric_name matching and can drop the
> duplicate string.

Looks fine:

Reviewed-by: Christoph Hellwig <h...@lst.de>

Reply via email to