On 29/10/18 15:23, Jens Axboe wrote:
> On 10/29/18 5:00 AM, Johannes Thumshirn wrote:
>> Hi Jens,
>>
>> On 25/10/18 23:10, Jens Axboe wrote:
>> [...]
>>> @@ -1487,8 +1485,6 @@ int blkcg_activate_policy(struct request_queue *q,
>>> out_bypass_end:
>>> if (q->mq_ops)
>>> blk_mq_unfreeze_queue(q);
>>> - else
>>> - blk_queue_bypass_end(q);
>>
>>>
>>>
>>
>> Now that we only have mq, do we still need all these checks for q->mq_ops?
>
> We need it for the cases where we can be passing in a stacked driver
> or an mq driver, or for cases where we explicitly register mq attributes,
> and that sort of thing.
>
Ah ok. Guess we'll have to live with it then.
Johannes
--
Johannes Thumshirn SUSE Labs
[email protected] +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
