On Mon, 2018-11-12 at 18:48 +0000, John Garry wrote: > On 12/11/2018 18:30, Joe Perches wrote: [] > > diff --git a/drivers/scsi/libsas/sas_internal.h > > b/drivers/scsi/libsas/sas_internal.h [] > > @@ -32,7 +32,10 @@ > > #include <scsi/libsas.h> > > #include <scsi/sas_ata.h> > > > > -#define sas_printk(fmt, ...) printk(KERN_NOTICE "sas: " fmt, ## > > __VA_ARGS__) > > +#ifdef pr_fmt > > +#undef pr_fmt > > +#endif > > +#define pr_fmt(fmt) "sas: " fmt > > Some other subsystem may try to include this header, and gets its > message prefix overwritten. Just a consequence for doing something bad, > right?
Right. And as this file is internal to drivers/scsi/libsas that seems very unlikely to occur. It also might useful to use the common debugging mechanisms and convert SAS_DPRINTK to pr_debug which would use the same #define pr_fmt.
