> > Hello Stanley, > > On 5/15/19 3:06 PM, Stanley Chu wrote: > > Some vendor-specific initialization flow may set its own > > auto-hibernate timer. In this case, do not overwrite timer value > > as "default value" in ufshcd_init(). > > > > Signed-off-by: Stanley Chu <stanley....@mediatek.com> > > --- > > drivers/scsi/ufs/ufshcd.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > > index e040f9dd9ff3..1665820c22fd 100644 > > --- a/drivers/scsi/ufs/ufshcd.c > > +++ b/drivers/scsi/ufs/ufshcd.c > > @@ -8309,7 +8309,7 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem > *mmio_base, unsigned int irq) > > UIC_LINK_HIBERN8_STATE); > > > > /* Set the default auto-hiberate idle timer value to 150 ms */ > > - if (hba->capabilities & MASK_AUTO_HIBERN8_SUPPORT) { > > + if (hba->capabilities & MASK_AUTO_HIBERN8_SUPPORT & !hba->ahit) { A typo?
> > hba->ahit = FIELD_PREP(UFSHCI_AHIBERN8_TIMER_MASK, > 150) | > > FIELD_PREP(UFSHCI_AHIBERN8_SCALE_MASK, 3); > > } > > > Looks good to me, > Reviewed-by: Alim Akhtar <alim.akh...@samsung.com>