Re: [PATCH] scsi: Add sysfs attributes for VPD pages 0h and 89h

[Bart Van Assche]

On 9/25/19 11:02 AM, Ryan Attard wrote:
  static struct bin_attribute *scsi_sdev_bin_attrs[] = {
+       &dev_attr_vpd_pg0,
        &dev_attr_vpd_pg83,
        &dev_attr_vpd_pg80,
+       &dev_attr_vpd_pg89,
        &dev_attr_inquiry,
        NULL
  };
diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
index 571ddb49b926..5e91b0d00393 100644
--- a/include/scsi/scsi_device.h
+++ b/include/scsi/scsi_device.h
@@ -137,6 +137,8 @@ struct scsi_device {
  #define SCSI_VPD_PG_LEN                255
        struct scsi_vpd __rcu *vpd_pg83;
        struct scsi_vpd __rcu *vpd_pg80;
+       struct scsi_vpd __rcu *vpd_pg89;
+       struct scsi_vpd __rcu *vpd_pg0;
        unsigned char current_tag;      /* current tag */
        struct scsi_target      *sdev_target;   /* used only for single_lun */

How about using numerical order consistently for the vpd related 
variables? Otherwise this patch looks fine to me.

Thanks,

Bart.