I would like to know peoples thought on making a change to the sd driver.
Specifically changing the
SD_TIMEOUT value from a define to a variable.
Reasons:
#define SD_TIMEOUT (30 * HZ)
This hard coded value of 30 seconds is to short for some hardware raid
devices. In most cases,
active fail over takes place long before the 30 second threshold, however if
the adapter is particularly
busy, this can sometimes take a bit longer. The end result is a kernel
panic.
I propose changing this to a variable:
int sd_timeout = 30 * HZ;
This allows other drivers (megaraid, aacraid, etc.) to extend this, thus
allowing fail over to take place
without interrupting the system.
if (sd_timeout < (60 * HZ) {
sd_timeout = (60 * HZ);
}
It looks like the other scsi drivers use their own timeout values. However,
most HW Raid adapters
depend on the scsi disk driver for such values.
Do people have any strong objections to this? I'll certainly make the
changes, I just want to hear
the good, the bad, and the ugly.
Cheers!!
-bmb-
Brian M. Boerner
System Software Developer
Adaptec, Inc.
Nashua, NH 03060
(603) 579-4625
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
