On Mon, Apr 16, 2007 at 06:11:30PM +0200, Andreas Gruenbacher wrote: > +static inline int > +nfsd_do_create(struct inode *dir, struct dentry *child, struct vfsmount *mnt, > + int mode) > +{ > + struct nameidata nd = { > + .dentry = child, > + .mnt = mnt, > + }; > + > + return vfs_create(dir, child, mode, &nd); > +} > +
Wouldn't it normally result in fewer instructions (on most architectures ... maybe not x86) to keep the same argument order as vfs_create? ie: static inline int nfsd_do_create(struct inode *dir, struct dentry *child, int mode, struct vfsmount *mnt) - To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html