On Sun, 24 Jun 2007, Petr Vandrovec wrote: > > -module_param(debug, bool, 0600); > > -MODULE_PARM_DESC(debug, "Debug enabled or not"); > > +static int __init root_plug_debug(char *str) > > +{ > > + debug = simple_strtol(str, NULL, 0); > > + return 1; > > +} > > +__setup("root_plug_debug=", root_plug_debug); > > is this necessary? What about just documenting > root_plug.{vendor_id,product_id,debug}, so it won't break existing root_plug > users (if there are any) ? I thought that typed module_param() is prefered > over untyped __setup()...
I didn't know module_param was preferred. The idea was that root_plug is example code, and should do the typical thing, which I thought would be __setup. I can easily change it if needed. -- James Morris <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html