On Tue, 2 Oct 2007, Kentaro Takeda wrote:

> +
> +     mb(); /* Instead of using spinlock. */
> +     ptr = domain_initializer_list;
> +     if (ptr) {
> +             while (ptr->next)
> +                     ptr = ptr->next;
> +             ptr->next = new_entry;
> +     } else
> +             domain_initializer_list = new_entry;
> +

Please use standard kernel list handling, per include/linux/list.h

Why do you need to avoid spinlocks for these manipulations?



- James
-- 
James Morris
<[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe 
linux-security-module" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to